Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grafana add p99, apiserver, tablet query #42

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

vagetablechicken
Copy link
Contributor

@vagetablechicken vagetablechicken commented Nov 22, 2023

  • p99, apiserver, tablet query prc metrics
  • overview expand, others collapse
  • delete "deploy query count total"
  • multi-value for variable "db", "deployment"

Copy link

github-actions bot commented Nov 22, 2023

Monitoring integration test

6 tests   - 1   6 ✔️  - 1   1m 1s ⏱️ - 1m 0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 4cd9a6b. ± Comparison against base commit e229b16.

This pull request removes 1 test.
tests.test_exporter ‑ test_deploy_response_time

♻️ This comment has been updated with latest results.

@aceforeverd
Copy link
Collaborator

make all rows (except the first row 'OpenMLDB Cluster Overview') in dashboard default closed, like original
Screenshot 2023-11-23 at 13 26 11

@aceforeverd
Copy link
Collaborator

May have more detailed name for the two row?
Screenshot 2023-11-23 at 13 28 04

Separate 'Tablet Detail' in different panel for different tablet endpoint may better. Also API server may have multiple instance

@aceforeverd
Copy link
Collaborator

db & deployment variable should support multi-value

Screenshot 2023-11-23 at 13 49 55

@aceforeverd
Copy link
Collaborator

Remove 'Deploy Query Count Total' in OpenMLDB Cluster Overview

@vagetablechicken
Copy link
Contributor Author

May have more detailed name for the two row? Screenshot 2023-11-23 at 13 28 04

Separate 'Tablet Detail' in different panel for different tablet endpoint may better. Also API server may have multiple instance

Each apiserver will be an instance, no need to seprate
And I want Tablet Detail to be the one, so we could see the difference in one panel, don't need to check multi panels to know some tablet is slow or heavy

@aceforeverd
Copy link
Collaborator

May have more detailed name for the two row? Screenshot 2023-11-23 at 13 28 04
Separate 'Tablet Detail' in different panel for different tablet endpoint may better. Also API server may have multiple instance

Each apiserver will be an instance, no need to seprate And I want Tablet Detail to be the one, so we could see the difference in one panel, don't need to check multi panels to know some tablet is slow or heavy

I still think there is too many series on single graph. To compare perf among tablets, then separate with different tp value ?

openmldb_mixin/openmldb_dashboard.json Outdated Show resolved Hide resolved
openmldb_mixin/openmldb_dashboard.json Outdated Show resolved Hide resolved
@aceforeverd aceforeverd added this to the 0.9.0 milestone Nov 24, 2023
@aceforeverd aceforeverd merged commit 5db2294 into main Dec 7, 2023
5 checks passed
@aceforeverd aceforeverd deleted the codespace-super-waddle-wvg94pp976wcv6pv branch December 7, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants