Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard broken memcached TCP connections #153

Closed
56quarters opened this issue Jul 2, 2024 · 0 comments · Fixed by #156
Closed

Discard broken memcached TCP connections #153

56quarters opened this issue Jul 2, 2024 · 0 comments · Fixed by #156
Labels
area:client Relating to the Memcached client bug Something isn't working

Comments

@56quarters
Copy link
Owner

In the MemcachedClient, we obtain a connection, run an operation, and then return the connection. We should only return the connection to the pool if the the Result is a Ok or the error is a ProtocolError.
@56quarters 56quarters added bug Something isn't working area:client Relating to the Memcached client labels Jul 2, 2024
@56quarters 56quarters changed the title Automatically discard broken connections Discard broken memcached TCP connections Jul 8, 2024
56quarters added a commit that referenced this issue Jul 9, 2024
@56quarters
Only return Memcached connections to the pool on success
96f3e07 
Only return connections to the pool if the request they were used for
was successful or it was an expected protocol error from the server.

Fixes #153
@56quarters 56quarters mentioned this issue Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:client Relating to the Memcached client bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only return Memcached connections to the pool on success 56quarters/mtop
1 participant
@56quarters