Don't attempt to resolve bare hostnames #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When connecting to Memcached servers, only attempt to resolve the hostnames to IP addresses when prefixed with `dns+`. If just a hostname is supplied, attempt to use it verbatim. This results in a better user experience since we get the benefits of using the system resolver and the expected hostname appears in the UI (instead of its IP). Fixes #151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to Memcached servers, only attempt to resolve the hostnames to IP addresses when prefixed with
dns+. If just a hostname is supplied, attempt to use it verbatim. This results in a better user experience since we get the benefits of using the system resolver and the expected hostname appears in the UI (instead of its IP).Fixes #151