-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/metrics reporting #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y points for incoming and outgoing messages. Dedicated controller classes that handle responsibilities for consumption reporting, QoE metrics reporting and playback/session management.
…andlerAdapter. That way we can use interfaces later to inject stubs when implementing unit tests
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for QoE Metrics Reporting. In addition, it refactors the code to make it more modular, use dependency injection and introduce a more clear separation of concerns.
QoeMetricsReporter
interface defining functions that need to be implemented for eachQoeMetricsReporter
class. The idea is to have different handlers for each scheme. Moreover, applications can implement this interface to define their own QoE Metrics Reporting class.QoeMetricsReporterExoplayer
that implementsQoeMetricsReporter
for the default 3GPP schemeurn:3GPP:ns:PSS:DASH:QM10
using Exoplayer.QoEMetricsReportingController
to manage the available instances ofQoeMetricsReporter
. Currently, one reporting class perscheme
is supported and can be registered viasetQoeMetricsReporterForScheme
. Once a QoEMetricsReport is requested by the MediaSessionHandler theQoEMetricsReportingController
identifies the rightQoeMetricsReporter
for the desired scheme and callsgetQoeMetricsReport
on this instance.ExoPlayerListener
class dispatches Exoplayer events via an internal event bus. By registering for specific events theQoeMetricsReporter
classes gain access to player related information such as quality switches.