Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions and move to GitHub actions #69

Merged
merged 4 commits into from
Apr 1, 2022
Merged

Conversation

flaeppe
Copy link
Contributor

@flaeppe flaeppe commented Feb 6, 2022


Based on #66 (comment)

I also tried including Django==3.2 but it failed, felt more reasonable to bump that in a separate PR.

* Remove testing with Django<2.2 and Python<3.7

- Newer versions of mypy also (incorrectly) don't accept overriding enum
  attributes when subclassing. Mitigated by temporarily removing
  attributes from Enum base class

* Move to GitHub actions
@flaeppe
Copy link
Contributor Author

flaeppe commented Feb 6, 2022

Not sure, but could there be some configuration needed to trigger actions to run? It worked fine in my fork (without having to configure anything): https://github.com/flaeppe/django-enumfield/actions/runs/1801846479

Or could it be that my base is master?

@Swamii
Copy link
Contributor

Swamii commented Apr 1, 2022

@flaeppe The actions doesn't seem to run when added from outside. For djedi-cms we merged the PR to another branch, opened a pr to master, ran the actions (which didn't even run immediately), and then merged it.

The move to getattr for the dunder properties seems fine. Is this mergable?

@flaeppe
Copy link
Contributor Author

flaeppe commented Apr 1, 2022

@Swamii Since mypy>=0.940 support for overriding dunder attributes is resolved. If we can run with that mypy version, I'd suggest we reverse the getattr-approach

@Swamii
Copy link
Contributor

Swamii commented Apr 1, 2022

@Swamii Since mypy>=0.940 support for overriding dunder attributes is resolved. If we can run with that mypy version, I'd suggest we reverse the getattr-approach

Let's do that then 👍

@flaeppe flaeppe requested a review from Swamii April 1, 2022 10:29
@flaeppe
Copy link
Contributor Author

flaeppe commented Apr 1, 2022

@Swamii I've bumped the changes now. Think it's mergable, too bad with CI though. Not sure why it won't trigger. Perhaps since all github action files are new?

@Swamii
Copy link
Contributor

Swamii commented Apr 1, 2022

Great let's just merge it. But last thing: changelog entry for these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants