-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions and move to GitHub actions #69
Conversation
* Remove testing with Django<2.2 and Python<3.7 - Newer versions of mypy also (incorrectly) don't accept overriding enum attributes when subclassing. Mitigated by temporarily removing attributes from Enum base class * Move to GitHub actions
Not sure, but could there be some configuration needed to trigger actions to run? It worked fine in my fork (without having to configure anything): https://github.com/flaeppe/django-enumfield/actions/runs/1801846479 Or could it be that my |
@flaeppe The actions doesn't seem to run when added from outside. For djedi-cms we merged the PR to another branch, opened a pr to master, ran the actions (which didn't even run immediately), and then merged it. The move to |
@Swamii Since |
Let's do that then 👍 |
@Swamii I've bumped the changes now. Think it's mergable, too bad with CI though. Not sure why it won't trigger. Perhaps since all github action files are new? |
Great let's just merge it. But last thing: changelog entry for these changes |
Remove testing with Django<2.2 and Python<3.7
Newer versions of mypy also (incorrectly) don't accept overriding enum
attributes when subclassing. Mitigated by temporarily removing
attributes from Enum base class.
Mypy ticket can be found here: Overriding non-enumeration attributes in Enum subclass fails python/mypy#12132
Move to GitHub actions
Based on #66 (comment)
I also tried including
Django==3.2
but it failed, felt more reasonable to bump that in a separate PR.