Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change max_tokens type to Option<u32> #233

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Change max_tokens type to Option<u32> #233

merged 1 commit into from
Jun 11, 2024

Conversation

MakotoE
Copy link
Contributor

@MakotoE MakotoE commented Jun 11, 2024 •
edited
Loading

Closes #232

64bit
64bit approved these changes Jun 11, 2024
View reviewed changes
Copy link
Owner

@64bit 64bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Thank you for a thorough fix!

@64bit 64bit merged commit f8a360a into 64bit:main Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64bit 64bit 64bit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreateChatCompletionRequest.max_tokens should be u32
2 participants
@MakotoE @64bit