fix: skip serialization to null if field is none in CreateRunRequest
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64bit
reviewed
Jun 16, 2024
async-openai/src/types/run.rs
Outdated
| @@ -228,7 +228,8 @@ pub struct CreateRunRequest { | |||
| pub tool_choice: Option<AssistantsApiToolChoiceOption>, | |||
|
|
|||
| /// Whether to enable [parallel function calling](https://platform.openai.com/docs/guides/function-calling/parallel-function-calling) during tool use. | |||
| pub parallel_tool_calls: Option<bool>, | |||
| #[serde(default)] | |||
| pub parallel_tool_calls: bool, | |||
There was a problem hiding this comment.
This may work, however it has a semantics of a "required" param, which in OpenAI API reference and spec - is not a required parameter. Even though it would take "default" value when not provided.
I think core of the issue is not having #[serde(skip_serializing_if = "Option::is_none")] on all the Option-al fields of CreateRunRequest - if this attribute fixes the issues its more aligned with semantics and consistency.
64bit
changed the title
CreateRunRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #234