Fix panic if forge is unreachable (woodpecker-ci#3944)

6543-forks · Sep 5, 2024 · 83dc513 · 83dc513
1 parent c3357c5
commit 83dc513
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/server/api/pipeline.go b/server/api/pipeline.go
@@ -64,7 +64,11 @@ func CreatePipeline(c *gin.Context) {
 
 	user := session.User(c)
 
-	lastCommit, _ := _forge.BranchHead(c, user, repo, opts.Branch)
+	lastCommit, err := _forge.BranchHead(c, user, repo, opts.Branch)
+	if err != nil {
+		_ = c.AbortWithError(http.StatusInternalServerError, fmt.Errorf("could not fetch branch head: %w", err))
+		return
+	}
 
 	tmpPipeline := createTmpPipeline(model.EventManual, lastCommit, user, &opts)