-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field 'pullRequest' as pull request title, number with link #164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 209 217 +8
Branches 54 56 +2
=========================================
+ Hits 209 217 +8
Continue to review full report at Codecov.
|
Sorry, I forget trigger events below:
I fix soon. plz wait. |
Add support variations: - pull_request_review - pull_request_review_comment - pull_request_target
Fixed event variation problem. |
Thanks for the PR.
I prefer |
Thanks!
It's the current format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot to submit review.
thanks! |
Add field
pullRequest
as pull request title, number with link.Motivation:
When triggered with pull request event, the commit is the SHA of the merge commit, and the message is "HEAD into BASE".
I can trace the pull request page from
job
orworkflow
, but it would be nice to be able to refer to the pull request directly.Note:
When it is triggered by push event, this field shows "n/a".
Discussions:Which is the best format for the pullRequest field?
Current:
<url | title #numer>
Alternative:
title <html_url | #numer>