opensuse: init: handle untrusted repositories when installing basic packages #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Hi @g7 there are some linting comments to fix 👍 |
…ackages If the image ships some untrusted repositories initial package installation might fail for these two separate reasons 1) The package list obtained with `zypper se` is polluted with warnings coming from zypper itself about those untrusted repositories 2) Even with a correct package list, zypper would still return a non-zero exit code to acknowledge those untrusted repositories This commit tries to tackle both points. The reason of checking for the exit code rather than using `--no-gpg-checks` is that this way untrusted packages wouldn't get in without user intervention. Signed-off-by: Eugenio Paolantonio <[email protected]>
|
Hi, thanks! It should be good now :) |
|
Thanks a lot @g7 for the contribution 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the image ships some untrusted repositories initial package installation might fail for these two separate reasons
zypper seis polluted with warnings comingfrom zypper itself about those untrusted repositories
code to acknowledge those untrusted repositories
This commit tries to tackle both points. The reason of checking for the exit code rather than using
--no-gpg-checksis that this way untrusted packages wouldn't get in without user intervention.