Illegal enum values

[romshark]

What happened?

Illegal enum values are accepted during code generation.
When you run the server and open the playground it says:

{
  "errors": [
    "Enum values cannot be named: true"
  ]
}

What did you expect?

I expect go run github.com/99designs/gqlgen to return an error when reading the schema file and encountering true, false or null in enum values according to the spec of October 2021.

Minimal graphql.schema and models to reproduce

https://github.com/romshark/gqlgen-2207-reproduction

versions

• go run github.com/99designs/gqlgen version: v0.17.7
• go version: go1.18.2 darwin/arm64

[ameyarao98]

This is an issue on https://github.com/vektah/gqlparser, and has been fixed with the following PR:
vektah/gqlparser#227

[frederikhors]

@romshark can you please verify?

[frederikhors]

@ameyarao98 thanks.

[romshark]

@romshark can you please verify?

I've upgraded the reproduction example to master (53ca207) but go generate still won't fail so this issue remains open. The PR for vektah/gqlparser looks good to me.

[ameyarao98]

@romshark gqlgen has not been updated to use the version of the gqlpraser that has this fix. To test this, clone master of https://github.com/vektah/gqlparser, add the following to the go.mod of your reproduction example

replace github.com/vektah/gqlparser/v2 => <path to cloned gqlparser>

and then run the generation