New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for non-enum values on validation #227

Merged

StevenACoffman merged 2 commits into vektah:master from ameyarao98:check_for_non+enum_values

Jun 25, 2022

Contributor

ameyarao98 commented Jun 25, 2022

According to this specification: https://spec.graphql.org/June2018/#sec-Enum-Value, true, false and null are not valid enum values. This PR adds validation for this.


          check for non enum values on validation

dd63349

coveralls commented Jun 25, 2022 •

edited

Loading

Coverage increased (+0.009%) to 92.253% when pulling afce55a on AmeyaRao98:check_for_non+enum_values into 0e3e4c2 on vektah:master.

ameyarao98 changed the title ~~Check for non -num values on validation~~ Check for non-enum values on validation


          add newline to end of schema_test.yml

afce55a

StevenACoffman merged commit 48f5a86 into vektah:master

ameyarao98 mentioned this pull request

Illegal enum values 99designs/gqlgen#2207

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet