Add in memory keyring. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An in-memory only keyring has been added. This will be useful for us because we have command line tools that we want to store longer term state in something like the OSX keychain, but later we may wish to automate the utility in a more transient, ephemeral way. In that case, the memory store will store the data for the duration of the run and recreate them on subsequent runs. I've additionally refactored slightly and added in a test for an Item.Equals function.
|
@mtibben Do you mind taking a look at this? This is a relatively straightforward PR. |
|
Thanks for the contribution @mikewilson-dd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An in-memory only keyring has been added. This will be useful for us because
we have command line tools that we want to store longer term state in
something like the OSX keychain, but later we may wish to automate the utility
in a more transient, ephemeral way. In that case, the memory store will store
the data for the duration of the run and recreate them on subsequent runs.
I've additionally refactored slightly and added in a test for an Item.Equals
function.
Note: I've tested this against vagrant and using the CLI, but it's not particularly useful outside of use as a library.