Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[33] Implements solution 1. for issue 33 #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[33] Implements solution 1. for issue 33 #42

wants to merge 1 commit into from

Conversation

asodeur
Copy link

@asodeur asodeur commented Mar 26, 2019

fixes #33

@sesam
Copy link

sesam commented May 30, 2019

LGTM. Recommend merge.

Maybe windows users (as in #33) who run sls from inside powershell might get a (for them) superfluous shell process wrapped around the java process, causing some tiny additional memory overhead. But handling that would add complexity. This PR strikes a good balance IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triqi triqi triqi approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not compatible with Windows
3 participants
@asodeur @sesam @triqi