Skip to content

Commit

Permalink
[New] add implicit role of graphics-document to svg element
Browse files Browse the repository at this point in the history
  • Loading branch information
jlp-craigmorten authored and ljharb committed Mar 31, 2024
1 parent f347e71 commit 24f2d0c
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 2 deletions.
3 changes: 2 additions & 1 deletion __tests__/src/elementRoleMap-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ const entriesList = [
[{"name": "strong"}, ["strong"]],
[{"name": "sub"}, ["subscript"]],
[{"name": "sup"}, ["superscript"]],
[{"name": "svg"}, ["graphics-document"]],
[{"attributes": [{"name": "aria-checked"}], "name": "button"}, ["switch"]],
[{"name": "table"}, ["table"]],
[{"name": "dfn"}, ["term"]],
Expand All @@ -131,7 +132,7 @@ const entriesList = [
test('elementRoleMap API', (t) => {
const predicate = (obj, [o]) => deepEqual(o, obj);

testIteration(t, elementRoleMap, entriesList, 112, predicate);
testIteration(t, elementRoleMap, entriesList, 113, predicate);

testForEach(t, elementRoleMap, entriesList, predicate);

Expand Down
3 changes: 2 additions & 1 deletion __tests__/src/roleElementMap-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ const entriesList = [
["strong", [{"name": "strong"}]],
["subscript", [{"name": "sub"}]],
["superscript", [{"name": "sup"}]],
["graphics-document", [{"name": "svg"}]],
["switch", [{"attributes": [{"name": "aria-checked"}], "name": "button"}]],
["table", [{"name": "table"}]],
["term", [{"name": "dfn"}, {"name": "dt"}]],
Expand All @@ -72,7 +73,7 @@ const entriesList = [
test('roleElementMap API', (t) => {
const predicate = (role, [r]) => role === r;

testIteration(t, roleElementMap, entriesList, 55, predicate);
testIteration(t, roleElementMap, entriesList, 56, predicate);

testForEach(t, roleElementMap, entriesList, predicate);

Expand Down
6 changes: 6 additions & 0 deletions scripts/roles.json
Original file line number Diff line number Diff line change
Expand Up @@ -3217,6 +3217,12 @@
"concept": {
"name": "article"
}
},
{
"concept": {
"name": "svg"
},
"module": "HTML"
}
],
"requiredContextRole": [],
Expand Down
6 changes: 6 additions & 0 deletions src/etc/roles/graphics/graphicsDocumentRole.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ const graphicsDocumentRole: ARIARoleDefinition = {
name: 'article',
},
},
{
concept: {
name: 'svg',
},
module: 'HTML',
},
],
requireContextRole: [],
requiredContextRole: [],
Expand Down

0 comments on commit 24f2d0c

Please sign in to comment.