-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DisclosureTriangleRole
model wrong?
#319
Comments
elycheea
added a commit
to carbon-design-system/ibm-products
that referenced
this issue
Jul 12, 2023
summary incorrectly flagged as non-interactive A11yance/axobject-query/issues/319
elycheea
added a commit
to carbon-design-system/ibm-products
that referenced
this issue
Jul 12, 2023
* chore: update dev dependencies * chore: update gallery * chore: remove useWorkspaces https://github.com/lerna/lerna/releases/tag/7.0.0 Ran `lerna repair` * chore: rollback framer * chore: fix jsx-a11y in OptionsTile summary incorrectly flagged as non-interactive A11yance/axobject-query/issues/319 --------- Co-authored-by: lee-chase <[email protected]> Co-authored-by: Elysia Hwang <[email protected]>
Here is the |
@dummdidumm your proposal is correct. |
Fixed in #339 |
@jessebeach sorry to ping - when can we expect this to get released? |
I'll try to get a release out on Sunday. |
@dummdidumm I just published v4.0.0: https://www.npmjs.com/package/axobject-query |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #273 the
DisclosureTriangleRole
model was adjusted and constraints/attributes were added. If I'm understanding this correctly, that means that a<summary>
tag now either needs aopen
oraria-expanded
attribute, but both these AFAIK should be on the parent<details>
tag instead. So if I'm understanding this correctly, theDisclosureTriangleRole
model should instead be reduced toIt could also very well be that I'm understanding the semantic meaning of
attributes
incorrectly, in which case could you briefly explain what it means?The text was updated successfully, but these errors were encountered: