Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix topsoil function #69

Closed
paolap opened this issue Oct 12, 2023 · 5 comments
Closed

fix topsoil function #69

paolap opened this issue Oct 12, 2023 · 5 comments
Assignees

Comments

@paolap
Copy link
Collaborator

paolap commented Oct 12, 2023

The current topsoil function is incorrect and at the best the one defined in APP4 will only suits specific soil depth levels.
The function should return the values for the top 10 cm of soil. So depending on the depth_bnds we should be able to interpolate this value.
AUS2200 top level is exactly 10cm so it cannot be used as an example

@paolap
Copy link
Collaborator Author

paolap commented Oct 12, 2023

I guess we could loop on the maximum boundary of depth_bnds, if that's less than 10cm than you can accumulate the all layer, if it's more than you calculate a proportion of what's in the first 10cm respect to the total thickness

@paolap
Copy link
Collaborator Author

paolap commented Oct 12, 2023

of course cable doesn't provide the depth_bnds base don this: ACCESS-Community-Hub/APP4#13

@paolap
Copy link
Collaborator Author

paolap commented Feb 14, 2024

Need to double check this is correct but I added function

@paolap
Copy link
Collaborator Author

paolap commented Apr 29, 2024

still need to update mappings and this should be also used for tsl and any other variable which is defined on "sdepth1"

@paolap
Copy link
Collaborator Author

paolap commented May 16, 2024

mappings updated

@paolap paolap closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants