Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back jq to spack buildcache push #169

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Add back jq to spack buildcache push #169

merged 1 commit into from
Jun 24, 2024

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Jun 24, 2024

See failed run: https://github.com/ACCESS-NRI/build-ci/actions/runs/9608705872/job/26501970133#step:4:8470

Using spack buildcache push without a list of specs assumes that you want to push all of them. However, if not all of them are installed (as is the case in our dependency image, which spack install --only dependencies ...) it fails. So leaving the jq in was needed.
To solve the original issue in #168, we now get both the name of the package, and the hash, so we can push up different versions of the same package.
We also remove the --allow-root flag as it is assumed in 0.21, and removed in 0.22.

In this PR:

  • setup-spack-envs.sh: Removed --allow-root (assumed in 0.21), added back hash-delineated jq

@CodeGat CodeGat self-assigned this Jun 24, 2024
@CodeGat CodeGat requested a review from jo-basevi June 24, 2024 02:29
Copy link
Contributor

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 82001db into main Jun 24, 2024
@CodeGat CodeGat deleted the spack-buildcache-jq branch June 24, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants