Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rewrite 1p Basis #120

Merged
merged 9 commits into from
Mar 11, 2022
Merged

WIP: Rewrite 1p Basis #120

merged 9 commits into from
Mar 11, 2022

Conversation

cortner
Copy link
Member

@cortner cortner commented Mar 10, 2022

This will provide a slightly less generic implementation of the 1p basis, but in return we will significantly reduce the amount of pointless wrapper code which should make ACE.jl more maintainable. In addition we will gain flexibility in other ways since this will be a step towards a "more differentiable" ACE.jl that will allow us to differentiate w.r.t. any parameter anywhere in the model.

@cortner
Copy link
Member Author

cortner commented Mar 11, 2022

What's left to do:

  • incorporate the distance transform into the value extraction
  • improved rrules
  • put the basis components into a named tuple instead of tuple to prepare for the nested parameters
  • revive the linear transformation of the basis

maybe all of these could be separate PRs.

@cortner
Copy link
Member Author

cortner commented Mar 11, 2022

I'm going to keep things separate, merge this and start another PR.

@cortner cortner merged commit 1125391 into main Mar 11, 2022
@cortner cortner deleted the co/rewrite1p branch March 11, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant