Add parameter freezing STOLayer and general performance fix
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheukHinHoJerry
changed the title
STOLayer and general performance fix
cortner
requested changes
Oct 5, 2023
src/lux.jl
Outdated
| @@ -63,6 +63,7 @@ evaluate!(out, basis::AbstractPoly4MLBasis, X, ps) = evaluate!(out, basis, X) | |||
| function evaluate(l::PolyLuxLayer, X, ps, st) | |||
| out = acquire!(st.pool, _outsym(X), _out_size(l.basis, X), _valtype(l.basis, X)) | |||
| evaluate!(out, l.basis, X, ps) | |||
| release!(X) | |||
There was a problem hiding this comment.
flag in LuxLayer on whether or not inputs can be released.
|
@CheukHinHoJerry -- the only change since we discussed it is the flag for whether or not to release? I.e. I should just go ahead and merge this? |
Yes - I think this is the only thing. And we talked about moving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates from this branch (To be updated)
STOLayerFlexArrayinterfaceSparseSymProdinside closuregeneric_matmul!inrruleofLinearLayercc @DexuanZhou
@cortner : will let you know once it is ready.