Skip to content

Commit

Permalink
Separate test and train error-table
Browse files Browse the repository at this point in the history
  • Loading branch information
Eszter Varga-Umbrich committed Aug 16, 2024
1 parent 0dc98b2 commit 21ee011
Showing 1 changed file with 23 additions and 4 deletions.
27 changes: 23 additions & 4 deletions mace/cli/run_train.py
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,9 @@ def run(args: argparse.Namespace) -> None:
)
all_data_loaders[test_name] = test_loader

train_valid_data_loader = {k: v for k, v in all_data_loaders.items() if k in ["train", "valid"]}
test_data_loader = {k: v for k, v in all_data_loaders.items() if k not in ["train", "valid"]}

for swa_eval in swas:
epoch = checkpoint_handler.load_latest(
state=tools.CheckpointState(model, optimizer, lr_scheduler),
Expand All @@ -822,21 +825,37 @@ def run(args: argparse.Namespace) -> None:
if args.distributed:
distributed_model = DDP(model, device_ids=[local_rank])
model_to_evaluate = model if not args.distributed else distributed_model
logging.info(f"Loaded model from epoch {epoch}")
if swa_eval:
logging.info(f"Loaded Stage two model from epoch {epoch} for evaluation")
else:
logging.info(f"Loaded model from epoch {epoch} for evaluation")

for param in model.parameters():
param.requires_grad = False
table = create_error_table(

table_train = create_error_table(
table_type=args.error_table,
all_data_loaders=train_valid_data_loader,
model=model_to_evaluate,
loss_fn=loss_fn,
output_args=output_args,
log_wandb=args.wandb,
device=device,
distributed=args.distributed,
)
table_test = create_error_table(
table_type=args.error_table,
all_data_loaders=all_data_loaders,
all_data_loaders=test_data_loader,
model=model_to_evaluate,
loss_fn=loss_fn,
output_args=output_args,
log_wandb=args.wandb,
device=device,
distributed=args.distributed,
)
logging.info("\n" + str(table))
logging.info("Error-table on TRAIN and VALID:\n" + str(table_train))
logging.info("Error-table on TEST:\n" + str(table_test))


if rank == 0:
# Save entire model
Expand Down

0 comments on commit 21ee011

Please sign in to comment.