New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pre-commit checks and github action runners #302

Merged

ilyes319 merged 4 commits into ACEsuit:develop from hatemhelal:checks

Mar 27, 2024

Contributor

hatemhelal commented Jan 19, 2024 •

edited

Loading

This PR adds:

pre-commit configuration to format code with black, isort and check lint with pylint
github actions to run pre-commit and pytest unittests
Additional dev install target to setup a virtualenv with required packages for checks

hatemhelal added 4 commits

January 19, 2024 17:09


          Adding pre-commit checks and github actions

7b3680e


          fix readme

f88c175

fix

64f127b


          add pre-commit install step

52abffe

hatemhelal marked this pull request as ready for review

January 19, 2024 17:23

Contributor

ilyes319 commented Jan 24, 2024

Very nice, thank you @hatemhelal

ilyes319 merged commit f690a7f into ACEsuit:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet