Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better fix for PR #405, fix patience check when swa is not active #411

Merged
merged 1 commit into from
May 10, 2024
Merged

Better fix for PR #405, fix patience check when swa is not active #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mace/tools/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,12 +244,12 @@ def train(

if valid_loss >= lowest_loss:
patience_counter += 1
if patience_counter >= patience and (swa.start is not None and epoch < swa.start):
if patience_counter >= patience and (swa is not None and epoch < swa.start):
logging.info(
f"Stopping optimization after {patience_counter} epochs without improvement and starting swa"
)
epoch = swa.start
elif patience_counter >= patience and (swa.start is None or epoch >= swa.start):
elif patience_counter >= patience and (swa is None or epoch >= swa.start):
logging.info(
f"Stopping optimization after {patience_counter} epochs without improvement"
)
Expand Down