Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tx signing metrics #1659

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Add tx signing metrics #1659

merged 2 commits into from
Feb 12, 2021

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Dec 30, 2020

Monitor the rate at which we sign channel txs and the duration of the signing operations.

Monitor the rate at which we sign channel txs and the duration of the
signing operations.
@t-bast t-bast requested a review from sstone December 30, 2020 09:33
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is fine, but should we rename the sign methods to signCommitment, signHtlc, signRevoked?

@t-bast
Copy link
Member Author

t-bast commented Jan 6, 2021

It's a bit more complicated than that: the metric tags will be slightly inaccurate because some 2nd-level txs (when closing) will be incorrectly assigned to htlc / commit txs.

But the rate of closing txs will be negligible compared to the rate of signing updated commitment txs, so I think the metric can ignore this subtlety, but renaming the methods could be confusing for readers when studying the closing flows.

@codecov-io
Copy link

Codecov Report

Merging #1659 (11e5478) into master (dd8975a) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1659      +/-   ##
==========================================
+ Coverage   85.92%   86.01%   +0.09%     
==========================================
  Files         151      151              
  Lines       11471    11487      +16     
  Branches      505      477      -28     
==========================================
+ Hits         9856     9881      +25     
+ Misses       1615     1606       -9     
Impacted Files Coverage Δ
...q/eclair/crypto/keymanager/ChannelKeyManager.scala 87.50% <ø> (ø)
...main/scala/fr/acinq/eclair/crypto/Monitoring.scala 100.00% <100.00%> (ø)
...air/crypto/keymanager/LocalChannelKeyManager.scala 88.63% <100.00%> (+2.92%) ⬆️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.06% <0.00%> (+0.08%) ⬆️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 89.67% <0.00%> (+1.08%) ⬆️
...main/scala/fr/acinq/eclair/router/Validation.scala 92.91% <0.00%> (+1.49%) ⬆️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 95.27% <0.00%> (+1.57%) ⬆️

@t-bast t-bast merged commit 15c1837 into master Feb 12, 2021
@t-bast t-bast deleted the signature-metrics branch February 12, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants