Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kamon tracing #1662

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Remove kamon tracing #1662

merged 1 commit into from
Jan 20, 2021

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Jan 5, 2021

It's costly, we're not using it, and it's too invasive.
There's no reason to keep it at the moment.

It's costly, we're not using it, and it's too invasive.
There's no reason to keep it at the moment.
@t-bast t-bast requested a review from pm47 January 5, 2021 13:30
@codecov-io
Copy link

Codecov Report

Merging #1662 (100a808) into master (dd8975a) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1662      +/-   ##
==========================================
- Coverage   85.92%   85.88%   -0.04%     
==========================================
  Files         151      151              
  Lines       11471    11418      -53     
  Branches      505      506       +1     
==========================================
- Hits         9856     9806      -50     
+ Misses       1615     1612       -3     
Impacted Files Coverage Δ
...ore/src/main/scala/fr/acinq/eclair/PimpKamon.scala 100.00% <ø> (ø)
...lockchain/bitcoind/rpc/ExtendedBitcoinClient.scala 92.85% <ø> (ø)
...clair/payment/send/MultiPartPaymentLifecycle.scala 95.03% <100.00%> (-0.21%) ⬇️
...r/acinq/eclair/payment/send/PaymentLifecycle.scala 92.80% <100.00%> (-0.53%) ⬇️
...e/src/main/scala/fr/acinq/eclair/router/Sync.scala 98.30% <100.00%> (-0.09%) ⬇️
...main/scala/fr/acinq/eclair/router/Validation.scala 91.11% <100.00%> (-0.30%) ⬇️
...cinq/eclair/blockchain/bitcoind/zmq/ZMQActor.scala 90.00% <0.00%> (-5.00%) ⬇️
...nq/eclair/blockchain/electrum/ElectrumWallet.scala 80.51% <0.00%> (+0.25%) ⬆️
...nq/eclair/blockchain/electrum/ElectrumClient.scala 73.89% <0.00%> (+0.36%) ⬆️
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 76.98% <0.00%> (+1.58%) ⬆️

@pm47
Copy link
Member

pm47 commented Jan 19, 2021

Is the issue more the cost, or the invasiveness? If it's the former, then why not simply disable it?

@t-bast
Copy link
Member Author

t-bast commented Jan 19, 2021

It's mostly the invasiveness (the cost is an added benefit, but it's quite negligible).

@t-bast t-bast merged commit 54ca292 into master Jan 20, 2021
@t-bast t-bast deleted the remove-tracing branch January 20, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants