Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/typos #1684

Merged
merged 3 commits into from
Feb 8, 2021
Merged

Fix/typos #1684

merged 3 commits into from
Feb 8, 2021

Conversation

ariskk
Copy link
Contributor

@ariskk ariskk commented Feb 6, 2021

Hi!
I am dipping my toes in Lightning and Eclair. While I was reading the docs, IntelliJ was suggesting a few typo fixes and I thought I should contribute them.

If that's ok, I may next fix collection deprecation warnings as I am reading and understanding the code.

@codecov-io
Copy link

Codecov Report

Merging #1684 (5e4c6dd) into master (f241ef9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1684      +/-   ##
==========================================
- Coverage   85.98%   85.97%   -0.01%     
==========================================
  Files         151      151              
  Lines       11455    11455              
  Branches      500      500              
==========================================
- Hits         9850     9849       -1     
- Misses       1605     1606       +1     
Impacted Files Coverage Δ
...clair/blockchain/electrum/ElectrumClientPool.scala 78.49% <100.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 93.70% <0.00%> (-1.58%) ⬇️
...nq/eclair/blockchain/electrum/ElectrumClient.scala 73.52% <0.00%> (-0.37%) ⬇️
...cala/fr/acinq/eclair/crypto/TransportHandler.scala 90.76% <0.00%> (+0.54%) ⬆️
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 77.77% <0.00%> (+0.79%) ⬆️

Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

I may next fix collection deprecation warnings

Please don't fix them yet. We're waiting a bit before we do, because we need to keep the master branch merge-able with the android branch that is on an older Java version (because it's used for eclair-mobile). We will fix all these warnings once we can safely move mobile apps to a different lightning backend (based on Kotlin). There are some additional details in #1393

docs/Configure.md Outdated Show resolved Hide resolved
Co-authored-by: Bastien Teinturier <[email protected]>
@t-bast t-bast merged commit 63d972b into ACINQ:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants