Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log ClosingType object #1781

Merged
merged 2 commits into from
May 3, 2021
Merged

Don't log ClosingType object #1781

merged 2 commits into from
May 3, 2021

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Apr 27, 2021

It may contain a lot of data and pollute the logs.

It may contain a lot of data and pollute the logs.
@t-bast t-bast requested a review from pm47 April 27, 2021 07:29
pm47
pm47 previously approved these changes May 3, 2021
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: EventType.Closed(closingType).label would look better

@codecov-commenter
Copy link

Codecov Report

Merging #1781 (d45934e) into master (62dd393) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1781      +/-   ##
==========================================
- Coverage   89.34%   89.31%   -0.03%     
==========================================
  Files         144      144              
  Lines       10917    10917              
  Branches      462      462              
==========================================
- Hits         9754     9751       -3     
- Misses       1163     1166       +3     
Impacted Files Coverage Δ
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.45% <100.00%> (-0.09%) ⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 94.02% <0.00%> (-1.50%) ⬇️

@t-bast t-bast merged commit 3669428 into master May 3, 2021
@t-bast t-bast deleted the logs-clean-up branch May 3, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants