Update secp256k1 submodule #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstone
force-pushed
the
snapshot/update-secp256k1
branch
2 times, most recently
from
e23a77b
to
2a3badd
Compare
sstone
force-pushed
the
snapshot/update-secp256k1
branch
from
565a679
to
62afbc8
Compare
|
I don't think we need to merge any update to the libsecp256k1 submodule until they officially ship musig2. I'd rather wait for the musig2 PR to be merged on their side before we update to a "final" version. |
|
We can wait. The musig2 branch that we use is behind secp2561k1's musig2 PR but there are only minor changes and an API change (counter-based nonce generation). I hope it will be released soon though :) |
sstone
force-pushed
the
snapshot/update-secp256k1
branch
from
7b1e117
to
c5b66d3
Compare
We're now at 461970682f56a8e15fc71ecab18d4537e50441fc.
sstone
force-pushed
the
snapshot/update-secp256k1
branch
from
cea19a3
to
453fceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counter-based nonce generation has been extracted into a separate method.