fix(network): use Promise.allSettled in AC check #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so the rest of the code continues, even if one of the submodules, like SU, fails. This is a temporary fix so that progress can be made before the Agora
WikiRik
approved these changes
Sep 21, 2024
Why does it count trailing spaces on comments smh
WikiRik
changed the title
serge1peshcoff
pushed a commit
that referenced
this pull request
Sep 21, 2024
## [1.37.3](1.37.2...1.37.3) (2024-09-21) ### Bug Fixes * **network:** use Promise.allSettled in AC check ([#2205](#2205)) ([f77d8c9](f77d8c9))
|
🎉 This PR is included in version 1.37.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.