-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(grainstats): GrainStats.get_max_min_feret() > measure.feret
Closes #798 Replaces the functionality for calculating minimum and maximum feret distances within the `GrainStats` class with the new `topostats.measure.feret.min_max_feret()`. + Reorder dictionary returned by `min_max_feret()`. + Dictionary is included in the `stats` dictionary built by `GrainStats` and saved as CSV. + Updates `tests/test_grainstats_minicircle.py::test_grainstats_regression` to include the co-ordinates. + Updates `tests/test_grainstats.py::test_process_scan*` to include co-ordinates. + Removes `GrainStats.get_max_min_feret()` and associated methods that are called as well as their tests. + Co-ordinates for min/max feret are included by default in HDF5 output now that they are part of the returned dataframe. These are rounded to 13 decimal places to address precision errors encountered on Windows machines running the test suite. Will have to rethink/change how results are returned by `GraintStats` class if height profiles are to be extracted. Probably most sensible to have profiling as a separate step conducted after GrainStats.
- Loading branch information
Showing
1 changed file
with
20 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters