Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Python 3.12 #930

Closed
Tracked by #800
ns-rse opened this issue Oct 7, 2024 · 1 comment
Closed
Tracked by #800

Remove support for Python 3.12 #930

ns-rse opened this issue Oct 7, 2024 · 1 comment
Assignees
@ns-rse
Labels
bug Something isn't working CI/CD

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Oct 7, 2024 •
edited
Loading

In light of #927 where we have discovered a performance regression of the dependency topoly with Python 3.12 we should, for the better tracing work and release remove support for Python 3.12 from TopoStats until this has been resolved.

pyproject.toml

requires-python = ">=3.9, <3.12"

.github/workflows/tests.yaml

        python-version: ["3.9", "3.10", "3.11"]
@ns-rse ns-rse mentioned this issue Oct 7, 2024
Closed
30 tasks
@ns-rse ns-rse self-assigned this Oct 7, 2024
@ns-rse ns-rse added bug Something isn't working CI/CD labels Oct 7, 2024
@ns-rse ns-rse mentioned this issue Oct 7, 2024
Open
ns-rse added a commit that referenced this issue Oct 7, 2024
@ns-rse
ci: restrict supported python version to <3.12
f9172f1 
Closes #930

Once Topoly performance regression has been resolved we should unpin this upper bound and ideally support upto Python
3.13.
@ns-rse ns-rse mentioned this issue Oct 7, 2024
Merged
@MaxGamill-Sheffield
Copy link
Collaborator

Don't think the auto close worked here so closing as fixed in #931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ns-rse ns-rse

Labels
bug Something isn't working CI/CD
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ns-rse @MaxGamill-Sheffield