Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Adds tmate to tests.yaml workflow #946

Merged
merged 1 commit into from
Oct 14, 2024
Merged

ci: Adds tmate to tests.yaml workflow #946

merged 1 commit into from
Oct 14, 2024

Conversation

ns-rse
Copy link
Collaborator

@ns-rse ns-rse commented Oct 14, 2024

Resolves #896

Adds debugging with tmate action to tests.yaml which
allows SSHing into GitHub Runners if tests have failed.

Resolves #896

Adds [debugging with tmate](https://github.com/marketplace/actions/debugging-with-tmate) action to `tests.yaml` which
allows SSHing into GitHub Runners _if_ tests have failed.
@ns-rse ns-rse requested review from SylviaWhittle, MaxGamill-Sheffield and llwiggins and removed request for SylviaWhittle October 14, 2024 11:16
Copy link
Collaborator

@SylviaWhittle SylviaWhittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this needs to be merged before it will work, but just in case, I thought I'd mention that for this PR, it doesn't seem to work?

image

@ns-rse
Copy link
Collaborator Author

ns-rse commented Oct 14, 2024

Thanks for the ✅

Nope that is by design, it only runs if: ${{ failure() }}occurs in earlier stages(line 56).

That way we don't leave sessions open and accessible if they pass.

@ns-rse ns-rse added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 8429156 Oct 14, 2024
14 checks passed
@ns-rse ns-rse deleted the ns-rse/896-tmate-ci branch October 14, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate tmate into CI to facilitate debugging
2 participants