-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(tracingfuncs): Numpydoc validation, PEP8 & tidying #947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/AFM-SPM/TopoStats into maxgamill-sheffield/800-btr-splining
…/TopoStats into SylviaWhittle/800-splining-tests
…nicircle.spm is still processed
….com/AFM-SPM/TopoStats into maxgamill-sheffield/800-btr-splining
…her grains set to 0
…y grain isn't removed
…on in disordered_trace.py
…racing' into maxgamill-sheffield/800-better-tracing
…b backend)" This reverts commit 07a4d96.
This commit is squash of seven individual commits that address Numpydoc validation - style(tracingfuncs): GL01/GL02 Numpydoc validation - style(tracingfuncs): SS06 Numpydoc validation - style(tracingfuncs): GL08 Numpydoc validation - style(tracingfuncs): PR01/RT01 Numpydoc validation Removes unused functions/methods... - fix(tracingfuncs): Removes circularTrace_old - fix(tracingfuncs): Remove unused getLocalPixelsBinary Renames methods to adhere to PEP8 - style(tracingfuncs): PEP8 renaming camel-case method to snake-case
Wrong target branch, ignore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is squash of seven individual commits that address Numpydoc validation
Removes unused functions/methods...
Renames methods to adhere to PEP8
Questions
check_vectors_candidate_points
- part 1This function (nee
checkVectorsCandidatePoints
) takes the parametersx
andy
but these are never used directly,rather
x
andy
are obtained anew in each iteration of this loop...We should be able to just drop
x
andy
as parameters to this method but I wanted to check as there aren't any testsfor these methods/functions.
check_vectors_candidate_points
- part 2I also noticed that in some places
check_vectors_candidate_points
(neecheckVectorsCandidatePoints
)was commented out (lines 83 and 187) in favour of using
find_next_best_point
(neefindNextBestPoint
) butcheck_vectors_candidate_points
is still used in some places. Is this deliberate? Can or shouldfind_next_best_point
replace all calls made to
check_vectors_candidate_points