Skip to content

Commit

Permalink
Metrics bug: server_lib should be config_lib (#113)
Browse files Browse the repository at this point in the history
* Metrics bug: server_lib should be config_lib

* format
  • Loading branch information
Bslabe123 authored Jun 4, 2024
1 parent 958678c commit a32be5d
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions run_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import jetstream_pt
from absl import app, flags
from jetstream.core import server_lib
from jetstream.core.config_lib import ServerConfig
from jetstream.core.config_lib import ServerConfig, MetricsServerConfig
from jetstream_pt.config import FLAGS, create_engine_from_config_flags

flags.DEFINE_integer("port", 9000, "port to listen on")
Expand Down Expand Up @@ -49,11 +49,9 @@ def main(argv: Sequence[str]):
)
print(f"server_config: {server_config}")

metrics_server_config: server_lib.MetricsServerConfig | None = None
metrics_server_config: MetricsServerConfig | None = None
if FLAGS.prometheus_port != 0:
metrics_server_config = server_lib.MetricsServerConfig(
port=FLAGS.prometheus_port
)
metrics_server_config = MetricsServerConfig(port=FLAGS.prometheus_port)

# We separate credential from run so that we can unit test it with local credentials.
# We would like to add grpc credentials for OSS.
Expand Down

0 comments on commit a32be5d

Please sign in to comment.