Remove JSON config mangling for Gemma ckpt #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix to the invalid JSON config file in HF Gemma pytorch ckpt is merged. We don't need to fix the invalid json in convert script.
https://huggingface.co/google/gemma-7b-it-pytorch/discussions/2#6667fe530ec7ed4422eb070c
https://huggingface.co/google/gemma-7b-pytorch/discussions/2#6667fdbf647001c39240a47e
https://huggingface.co/google/gemma-2b-pytorch/discussions/2#6667fdab51545a8b46c3a121
Other gemma pytorch ckpts are handled by HF staff as well.
Test