Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Allow PP + megablox #1009

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] Allow PP + megablox #1009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05b3610
Megablox + PP work together
gobbleturk Nov 2, 2024
60c0caf
Megablox + PP work together
gobbleturk Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MaxText/pyconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ def update_model_vars(base_config_path, raw_keys, config_name: str):

def validate_megablox_parallelism(raw_keys):
if raw_keys["megablox"] and (
using_sequence_parallelism(raw_keys) or using_pipeline_parallelism(raw_keys) or using_expert_parallelism(raw_keys)
using_sequence_parallelism(raw_keys) or using_expert_parallelism(raw_keys)
):
raise ValueError("Currently we only support Megablox with data and tensor parallelism.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to update the message in ValueError. Looking forward to see some baseline metrics! Thanks Matt!

tensor_parallelism = raw_keys["ici_tensor_parallelism"] * raw_keys["dcn_tensor_parallelism"]
Expand Down
Loading