-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XPK cleanup: integ tests and code cleanup #121
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, Victor
@@ -21,14 +21,14 @@ on: | |||
|
|||
env: | |||
# Names must be unique in parallel running tests. | |||
TPU_CLUSTER_NAME: build-xpk-2-v4-8-nodepools | |||
TPU_CLUSTER_NAME: build-xpk-2-v4-8-nodepools-${{ github.run_id }}-${{ github.run_attempt }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run_attempt may uniquely identify the cluster name, do you still think run_id is needed? https://stackoverflow.com/questions/54310050/how-to-version-build-artifacts-using-github-actions
runs-on: [ubuntu-20.04] | ||
concurrency: # We support one build or nightly test to run at a time currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious to know how "one of build or nightly" is ensured. I think the concurrency of jobs is once per group.
Improvements:
system: SystemCharacteristics
to arg types and return valuesadd_env_config
now returns int instead of using exceptions maintaining consistent flow with other functions in xpkTesting:
Integ tests