Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XPK cleanup: integ tests and code cleanup #121

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

XPK cleanup: integ tests and code cleanup #121

wants to merge 7 commits into from

Conversation

Obliviour
Copy link
Collaborator

@Obliviour Obliviour commented Apr 11, 2024

Improvements:

  1. Use enum for accelerator type
  2. remove usage of device type based on --tpu-type / --device-type check everywhere. Do this in one place.
  3. Remove h100 device specific workflow in favor of GPU specific workflows
  4. Add nightly test for xpk help commands
  5. Add nightly tests for autoscaling with xpk
  6. Remove outdated future steps
  7. Add system: SystemCharacteristics to arg types and return values
  8. add_env_config now returns int instead of using exceptions maintaining consistent flow with other functions in xpk

Testing:

Integ tests

@Obliviour Obliviour changed the title Refactor of XPK XPK cleanup: integ tests and code cleanup Apr 12, 2024
Copy link
Collaborator

@RoshaniN RoshaniN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, Victor

@@ -21,14 +21,14 @@ on:

env:
# Names must be unique in parallel running tests.
TPU_CLUSTER_NAME: build-xpk-2-v4-8-nodepools
TPU_CLUSTER_NAME: build-xpk-2-v4-8-nodepools-${{ github.run_id }}-${{ github.run_attempt }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_attempt may uniquely identify the cluster name, do you still think run_id is needed? https://stackoverflow.com/questions/54310050/how-to-version-build-artifacts-using-github-actions

runs-on: [ubuntu-20.04]
concurrency: # We support one build or nightly test to run at a time currently.
Copy link
Collaborator

@RoshaniN RoshaniN Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to know how "one of build or nightly" is ensured. I think the concurrency of jobs is once per group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants