-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create-ray-cluster subcommand #202
Open
mbzomowski
wants to merge
14
commits into
main
Choose a base branch
from
raycluster-create
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+322
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenwang28
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mark! A few comments
mbzomowski
force-pushed
the
raycluster-create
branch
from
October 16, 2024 18:10
ce87583
to
b43765a
Compare
pawloch00
reviewed
Oct 17, 2024
pawloch00
reviewed
Oct 17, 2024
pawloch00
reviewed
Oct 17, 2024
pawloch00
reviewed
Oct 17, 2024
pawloch00
reviewed
Oct 18, 2024
pawloch00
reviewed
Oct 18, 2024
mbzomowski
force-pushed
the
raycluster-create
branch
from
October 23, 2024 19:03
4d621d2
to
3dfc194
Compare
pawloch00
reviewed
Oct 24, 2024
pawloch00
reviewed
Oct 24, 2024
allenwang28
reviewed
Oct 24, 2024
richardsliu
reviewed
Oct 24, 2024
mbzomowski
force-pushed
the
raycluster-create
branch
from
October 28, 2024 22:20
682f134
to
137988c
Compare
pawloch00
reviewed
Nov 5, 2024
pawloch00
approved these changes
Nov 5, 2024
richardsliu
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
-Adds the create-ray subcommand, which creates a RayCluster with a head node and a workergroup that utilizes all TPU resources
Testing / Documentation
Manually tested
python3 xpk.py cluster create-ray ...
with several different TPU configurations. Also added a nightly test for RayCluster creation.