Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create-ray-cluster subcommand #202

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add create-ray-cluster subcommand #202

wants to merge 14 commits into from

Conversation

mbzomowski
Copy link
Collaborator

@mbzomowski mbzomowski commented Oct 9, 2024

Fixes / Features

-Adds the create-ray subcommand, which creates a RayCluster with a head node and a workergroup that utilizes all TPU resources

Testing / Documentation

Manually tested python3 xpk.py cluster create-ray ... with several different TPU configurations. Also added a nightly test for RayCluster creation.

  • [ y ] Tests pass
  • [ n ] Appropriate changes to documentation are included in the PR (will include in subsequent PR)

Copy link

@allenwang28 allenwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark! A few comments

src/xpk/commands/cluster.py Show resolved Hide resolved
src/xpk/core/ray.py Outdated Show resolved Hide resolved
src/xpk/core/ray.py Show resolved Hide resolved
src/xpk/core/ray.py Outdated Show resolved Hide resolved
src/xpk/core/ray.py Outdated Show resolved Hide resolved
src/xpk/core/ray.py Outdated Show resolved Hide resolved
src/xpk/core/ray.py Outdated Show resolved Hide resolved
src/xpk/core/ray.py Show resolved Hide resolved
src/xpk/commands/cluster.py Show resolved Hide resolved
src/xpk/core/ray.py Outdated Show resolved Hide resolved
src/xpk/core/ray.py Show resolved Hide resolved
src/xpk/core/ray.py Show resolved Hide resolved
src/xpk/core/ray.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants