Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable GCP Filestore on cluster #215

Open
wants to merge 11 commits into
base: development
Choose a base branch
from
Open

enable GCP Filestore on cluster #215

wants to merge 11 commits into from
+116 −16

Conversation

pawloch00
Copy link
Collaborator

@pawloch00 pawloch00 commented Oct 23, 2024 •
edited
Loading

Fixes / Features

  • Enable passing GCPFilestore flag during cluster creation so cluster create has --addons GcpFilestoreCsiDriver flag.
  • add GCPFilestore type to storage create command so if GCPFilestoreCsiDriver is not enabled cluster is updated.

Testing / Documentation

Testing details.

  • [ y/n ] Tests pass
  • [ y/n ] Appropriate changes to documentation are included in the PR

@pawloch00
add flag parser and enable GCPFilestore on cluster
0ecf53c 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
update cluster with gcp filestore
8491a43 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
fix linter
f121fa9 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
filestore -> gcpfilestore
0bc8636 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
filetore -> gcpfilestorage
9679b7b 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
enable gcpfilestore on cluster creation
80ae221 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
pyink
89c3cd0 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
fix string formatting
729546c 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00 pawloch00 marked this pull request as ready for review October 29, 2024 13:49
@pawloch00 pawloch00 requested review from sharabiani and BluValor and removed request for Obliviour October 29, 2024 13:49
@pawloch00
fix naming
80f8e63 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
fix multiple addons usage
e18f696 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00 pawloch00 marked this pull request as draft November 4, 2024 11:41
@pawloch00
+= -> append
8b2940f 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00 pawloch00 marked this pull request as ready for review November 4, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharabiani sharabiani Awaiting requested review from sharabiani

@BluValor BluValor Awaiting requested review from BluValor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pawloch00