Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ROOT load libraries without the .so extension #638

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Jul 10, 2024

BEGINRELEASENOTES

  • Make ROOT load libraries without the .so extension

ENDRELEASENOTES

See key4hep/EDM4hep#339 and key4hep/EDM4hep#338. This means no one is running the tests on MacOS 😄

@tmadlener
Copy link
Collaborator

Well, maybe someone has, but they ignored the failing tests ;)

There is another error message with an explicit .so here:

print("Unable to load podio, make sure that libpodio.so is in LD_LIBRARY_PATH")

@jmcarcell
Copy link
Member Author

jmcarcell commented Jul 10, 2024

I don't have a mac handy to check but maybe it doesn't matter because of

set(CMAKE_SHARED_LIBRARY_SUFFIX ".so")

@tmadlener
Copy link
Collaborator

Ah yes, that probably also affects mac OS builds. Not sure if mac OS still allows shared libs with .so ending though. Anyhow, for this PR it should not matter too much as long as ROOT does the "right thing".

@tmadlener tmadlener merged commit acfe93f into AIDASoft:master Jul 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants