Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intel16 Upstreaming #1304

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dan-fritchman
Copy link

  • Merges commits in master as of 9/28/23 into the intel16 branch
  • Request to merge these back into master

@soneryaldiz - couple questions -

  • Are there any (known) changes that would/ should break compatibility with the PDK package?
  • Do you guys have some internal edition that renders this irrelevant?
  • Overall - do ya want intel16 merged?

@dan-fritchman dan-fritchman marked this pull request as draft September 28, 2023 23:06
@dan-fritchman
Copy link
Author

Marking as a draft; this needs a massage just to compile, at least for me.
And pending the questions about whether the project wants it.

@soneryaldiz
Copy link
Collaborator

@dan-fritchman , I am fine with merging intel16 to master.
Do you mean internal edition of ALIGN-Public? No, we use the public repository as well.

Copy link
Collaborator

@soneryaldiz soneryaldiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dan-fritchman
Copy link
Author

Great thanks.

And I suppose my question really breaks in two, regarding

  • (a) ALIGN itself - which you've answered. And
  • (b) The PDK package - which is perhaps better reserved for a different forum.

@dan-fritchman dan-fritchman marked this pull request as ready for review October 16, 2023 20:16
@dan-fritchman
Copy link
Author

OK after testing in my own setup, this looks ready to merge.

@dan-fritchman
Copy link
Author

It seems the CircleCI tests fail because it's a fork, and they attempt to clone the source from this repo.
Let me know what if anything you wanna do there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants