Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC-379: Datim Reports #1282

Merged
merged 15 commits into from
Jun 29, 2023
Merged

POC-379: Datim Reports #1282

merged 15 commits into from
Jun 29, 2023

Conversation

Alfred-Mutai
Copy link
Collaborator

No description provided.

app/reporting-framework/base-mysql.report.js Outdated Show resolved Hide resolved
@@ -63,8 +63,10 @@ export class MultiDatasetPatientlistReport extends MultiDatasetReport {

let that = this;
return new Promise((resolve, reject) => {
console.log('additionalParams', additionalParams);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up the console logs

this.generateReport(additionalParams)
.then((results) => {
console.log('results', results);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

);
reportParams.requestParams.isAggregated = true;

let service = new TXMLSummaryReportService(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let service = new TXMLSummaryReportService(
const service = new TXMLSummaryReportService(

);
reportParams.requestParams.isAggregated = true;

let service = new TXNEWSummaryReportService(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let service = new TXNEWSummaryReportService(
const service = new TXNEWSummaryReportService(

);
reportParams.requestParams.isAggregated = true;

let service = new TXRTTSummaryReportService(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let service = new TXRTTSummaryReportService(
const service = new TXRTTSummaryReportService(

Copy link
Member

@drizzentic drizzentic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future consider having a PR for a feature. Review is better when we can evaluate small bits of the code.

@hiqedme
Copy link
Member

hiqedme commented Jun 29, 2023

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants