-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC-379: Datim Reports #1282
POC-379: Datim Reports #1282
Conversation
@@ -63,8 +63,10 @@ export class MultiDatasetPatientlistReport extends MultiDatasetReport { | |||
|
|||
let that = this; | |||
return new Promise((resolve, reject) => { | |||
console.log('additionalParams', additionalParams); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean up the console logs
this.generateReport(additionalParams) | ||
.then((results) => { | ||
console.log('results', results); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
); | ||
reportParams.requestParams.isAggregated = true; | ||
|
||
let service = new TXMLSummaryReportService( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let service = new TXMLSummaryReportService( | |
const service = new TXMLSummaryReportService( |
); | ||
reportParams.requestParams.isAggregated = true; | ||
|
||
let service = new TXNEWSummaryReportService( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let service = new TXNEWSummaryReportService( | |
const service = new TXNEWSummaryReportService( |
); | ||
reportParams.requestParams.isAggregated = true; | ||
|
||
let service = new TXRTTSummaryReportService( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let service = new TXRTTSummaryReportService( | |
const service = new TXRTTSummaryReportService( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future consider having a PR for a feature. Review is better when we can evaluate small bits of the code.
Co-authored-by: Kipchumba Bett <[email protected]>
LGTM |
No description provided.