Make mion and bion inline functions for aprox nets #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a4eaec5.
this still only works with aprox19
zingale
approved these changes
Jul 18, 2023
maxpkatz
added a commit
to maxpkatz/Microphysics
that referenced
this pull request
Jul 19, 2023
The goal of this change is to remove the global data from actual_network_data.cpp, which in turn allows elimination of that file. Rather than an array, this can be handled with a constexpr function emulating the array. The new function is templated to allow compile-time evaluation of the binding energy. However, not all locations in Microphysics will be readily available to switch to a compile-time evaluation, so a "legacy" interface which accepts the species index at runtime is also provided. (This requires constexpr_for to be available in the network, so it is moved to a separate utility location.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to remove the global data from actual_network_data.cpp, which in turn allows elimination of that file. Rather than an array, this can be handled with a constexpr function emulating the array. The new function is templated to allow compile-time evaluation of the binding energy. However, not all locations in Microphysics will be readily available to switch to a compile-time evaluation, so a "legacy" interface which accepts the species index at runtime is also provided. (This requires constexpr_for to be available in the network, so it is moved to a separate utility location.)