-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template rate indices and corresponding changes for NSE_NET #1269
Conversation
It seems like a lot of time is taken when constructing fcn and getting the partition function. I still want to optimize the |
can you resolve these conflicts? |
networks/aprox13/actual_network.H
Outdated
{ | ||
// p_index is for photoionization proton | ||
extern AMREX_GPU_MANAGED int p_index; | ||
extern AMREX_GPU_MANAGED int h1_index; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't these actually be constexpr int p_index = ...
?
the values don't change, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. I fixed that, also did a corresponding change in pynucastro pr.
Should this update ignition_simple too? |
Yes, I missed that. Now it is updated. |
Based on Pr#1231.
Added rate indices for aprox networks and iso7 to be compatible updated pynucastro c++ network template.
Delete unnecessary files that declare and initialize rate indices since now we do it directly via pynucastro, or hard coded it for aprox networks.