-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decompose get_nse_state into two separate functions #1276
Merged
zingale
merged 97 commits into
AMReX-Astro:development
from
zhichen3:separate_get_nse_state
Jul 17, 2023
Merged
decompose get_nse_state into two separate functions #1276
zingale
merged 97 commits into
AMReX-Astro:development
from
zhichen3:separate_get_nse_state
Jul 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yut23
reviewed
Jul 14, 2023
this has conflicts now |
zingale
approved these changes
Jul 17, 2023
maxpkatz
pushed a commit
to maxpkatz/Microphysics
that referenced
this pull request
Jul 19, 2023
Here I separated get_nse_state into two separate functions, one that calculates the exponent part of the nse mass fraction (depends on chemical potentials) and the other calculates components that do not depend on chemical potentials. This way we don't have to compute unnecessary parts when we solve for chemical potentials, mu_p and mu_n during hybrid solver, which includes getting the partition function. Heres the new profile, it brings down # of calls for get_partition_functions from 900,000,000+ (from pr1274) to 200,000,000+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I separated get_nse_state into two separate functions, one that calculates the exponent part of the nse mass fraction (depends on chemical potentials) and the other calculates components that do not depend on chemical potentials.
This way we don't have to compute unnecessary parts when we solve for chemical potentials, mu_p and mu_n during hybrid solver, which includes getting the partition function.
Heres the new profile, it brings down # of calls for get_partition_functions from 900,000,000+ (from pr1274) to 200,000,000+