Update CUDA compilation test to cover more cases #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds CUDA coverage for both partition functions and self-consistent NSE.
|
to keep the test compilation time down, I would suggest replacing the current subch_simple with the ase network. ase tests everything that is in subch_simple already, so we don't need them both |
|
In that case we might as well use URCA-simple instead of subch_simple, since that will cover tabular rates too |
yut23
changed the title
zingale
approved these changes
Aug 6, 2023
maxpkatz
pushed a commit
to maxpkatz/Microphysics
that referenced
this pull request
Aug 9, 2023
This adds CUDA coverage for both partition functions and self-consistent NSE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds CUDA coverage for tabular rates, partition functions, and self-consistent NSE.