create a struct to hold the Microphysics runtime parameters #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we will also need to modify CMakeLists to reflect these changes. @BenWibking ? |
yut23
reviewed
May 6, 2024
There was a problem hiding this comment.
This need to be updated since #1536
yut23
reviewed
May 6, 2024
yut23
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now creates a header extern_type.H with a struct extern_t that holds all
of the runtime parameters for Microphysics. The struct is filled on initialization
and returned by init_extern_parameters(). This can replace the global version
of the runtime parameters.
This also revives the test_parameters unit test to show how to access things.