Implement ISM chemistry including metals and dust #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 15, 2024 14:17
added 10 commits
August 22, 2024 20:39
psharda
commented
Aug 22, 2024
added 11 commits
August 22, 2024 23:23
… namespace C used for physical constants
BenWibking
reviewed
Aug 27, 2024
BenWibking
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Looks good to me, but I'd still like @zingale to weight in on what the right thing to do about the in-line iterative solve for the dust temperature and how to handle convergence failure there.
psharda
commented
Aug 29, 2024
7 tasks
added 4 commits
August 29, 2024 15:51
zingale
pushed a commit
that referenced
this pull request
Aug 29, 2024
We now use a function that does the charge balance for primordial chemistry, similar to that done for metal chemistry in #1642
zingale
pushed a commit
that referenced
this pull request
Sep 19, 2024
We build on #1642 to add cosmic ray chemistry and heating to the metal chemistry network. Two new tests are added, which use cosmic rays and evolves networks at 1 and 1e-4 Solar metallicity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will build on the existing primordial ISM chemistry network to include a minimal network with metals and dust. Also added are the tests that go with this PR, where the network is integrated at 7 different metallicities and the test solutions are compared against reference solutions.