Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle ices in metal chemistry #1650

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Correctly handle ices in metal chemistry #1650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4812f9a
handle ices correctly
Sep 17, 2024
400ffae
update reference solutions
psharda Sep 17, 2024
4451332
update ref file lines
psharda Sep 17, 2024
7b6a6af
update ref file lines
psharda Sep 17, 2024
ceb00c0
update ref file lines
psharda Sep 17, 2024
d066511
updated ref soln
psharda Sep 17, 2024
a33d541
updated ref soln
psharda Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/burn_cell_metal_chem.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ jobs:
cd unit_test/burn_cell_metal_chem

declare -A line_numbers_map=(
["Z=1"]="4461 4463 4465 4467 4468 4471 4472 4475 4481 4486"
["Z=1"]="4450 4452 4454 4456 4457 4460 4461 4464 4470 4475"
["Z=1_z10"]="1613 1615 4456 4458 4460 4463 4470 4476 4481"
["Z=1e-1"]="4438 4440 4442 4444 4445 4448 4449 4452 4458 4463"
["Z=1e-2"]="4438 4440 4442 4444 4445 4448 4449 4452 4458 4463"
["Z=1e-3"]="4438 4440 4442 4444 4445 4448 4449 4452 4458 4463"
["Z=1e-4"]="4438 4440 4442 4444 4445 4448 4449 4452 4458 4463"
["Z=1e-5"]="4438 4440 4442 4444 4445 4448 4449 4452 4458 4463"
["Z=1e-6"]="4438 4440 4442 4444 4445 4448 4449 4452 4458 4463"
["Z=1e-6"]="4451 4453 4455 4457 4458 4461 4462 4465 4471 4476"
)

declare -A ref_map=(
Expand Down Expand Up @@ -92,9 +92,11 @@ jobs:

# Adjust the line number for the reference file
if [[ "$Z" == "Z=1" ]]; then
reference_line_number=$((line_number - 4460))
reference_line_number=$((line_number - 4449))
elif [[ "$Z" == "Z=1_z10" ]]; then
reference_line_number=${ref_line_number_z10[$index]}
elif [[ "$Z" == "Z=1e-6" ]]; then
reference_line_number=$((line_number - 4450))
else
reference_line_number=$((line_number - 4437))
fi
Expand Down
4 changes: 2 additions & 2 deletions EOS/metal_chem/_parameters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
eos_gamma_default real 1.4

# define the specie names, and their masses and gammas
species_1_name string "co_ice"
species_1_name string "co_total"
species_1_gamma real 5./3.
species_1_mass real 0.0

species_2_name string "h2o_ice"
species_2_name string "h2o_total"
species_2_gamma real 5./3.
species_2_mass real 0.0

Expand Down
Loading
Loading