Particles: Restructure #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
restructure-particles
branch
from
9d1959c
to
dd336e3
Compare
ax3l
force-pushed
the
restructure-particles
branch
from
dd336e3
to
be04bb1
Compare
The AMReX particle logic is heavily templated. For simpler maintainance, we move all declarations into header file and define needed types recursively from the particle container.
ax3l
force-pushed
the
restructure-particles
branch
from
be04bb1
to
9bdda1f
Compare
See killed processes in CI.
ax3l
commented
Mar 11, 2024
Comment on lines
+41
to
+44
| // For legacy AoS + SoA particles, we register a particle and superparticle. | ||
| // The latter adds the SoA attributes. Avoid to double-register those types. | ||
| /* | ||
| static std::unordered_set<std::array<int, 2>> registered; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AMReX particle logic is heavily templated. For simpler maintenance, we move all declarations into header file and define needed types recursively from the particle container.